Add Container Registry Integration Tests for GCP #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guineveresaenger
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
force-pushed
the
guin/gcp-registry
branch
from
18ed5af to
8bbb32f
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
2 similar comments
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
jazzyfresh
reviewed
Feb 28, 2023
| with: | ||
| install_components: gke-gcloud-auth-plugin | ||
| - name: Login to Google Cloud Registry | ||
| run: gcloud --quiet auth configure-docker |
There was a problem hiding this comment.
workflow changes go in ci-mgmt
jazzyfresh
reviewed
Feb 28, 2023
| build: "./app", | ||
| build: { | ||
| context: "app" | ||
| }, | ||
| imageName: imageName, | ||
| registry: registryInfo, |
There was a problem hiding this comment.
comment on old code: we dont need this bc it will infer the registry info from the image name
jazzyfresh
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Feb 28, 2023
We use gcloud auth in CI so we won't need to pass any registry info.
guineveresaenger
force-pushed
the
guin/gcp-registry
branch
from
4c27d4c to
87d4741
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #491