Add Container Registry Integration Tests for AWS ECR #502
Conversation
guineveresaenger
force-pushed
the
guin/aws-registry
branch
from
010841c to
043fd30
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
11 similar comments
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
force-pushed
the
guin/aws-registry
branch
from
96c2683 to
c25a970
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
| region := os.Getenv("AWS_REGION") | ||
| if region == "" { | ||
| t.Skipf("Skipping test due to missing AWS_REGION environment variable") | ||
| } |
There was a problem hiding this comment.
Is there a reason why we let this be environmentally controlled, instead of just hard coding it to a specific zone?
I can't see a scenario where we will want to change the zone our tests run in, but I might be missing something.
There was a problem hiding this comment.
Yeah, I see what you mean - the only thing I can think of is some sort of lazy failsafe that tries to capture both user error when running tests locally and CI failing to behave properly/regional AWS outage.
I'm not against just hard coding the region right here; but if that's a pattern we want to clean up we should probably do it across more than just this provider.
Fixes #487.
Adds integration tests for AWS ECR in node, python, go, and dotnet.
Removes extraneous duplicate test
Removes extraneous JS test