Add Example documentation for Image #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
iwahbe
approved these changes
Feb 3, 2023
Makefile
Outdated
| .PHONY: development build build_sdks examples install_go_sdk install_java_sdk install_python_sdk install_sdks only_build build_dotnet build_go build_java build_nodejs build_python clean cleanup help install_dotnet_sdk install_nodejs_sdk install_plugins lint_provider provider test tfgen |
There was a problem hiding this comment.
Just so diffs become meaningful (assuming we are now editing this file by hand.
Suggested change
| .PHONY: development build build_sdks examples install_go_sdk install_java_sdk install_python_sdk install_sdks only_build build_dotnet build_go build_java build_nodejs build_python clean cleanup help install_dotnet_sdk install_nodejs_sdk install_plugins lint_provider provider test tfgen | |
| .PHONY: development build build_sdks \ | |
| examples install_go_sdk install_java_sdk \ | |
| install_python_sdk install_sdks only_build \ | |
| build_dotnet build_go build_java \ | |
| build_nodejs build_python clean \ | |
| cleanup help install_dotnet_sdk \ | |
| install_nodejs_sdk install_plugins lint_provider \ | |
| test tfgen provider |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
iwahbe
reviewed
Feb 3, 2023
Does the PR have any schema changes?Looking good! No breaking changes found. |
guineveresaenger
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Feb 3, 2023
This addition supports Makefile changes introduced to pulumi-docker in pulumi/pulumi-docker#479.
guineveresaenger
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Feb 3, 2023
* Add logic to add a `docs` Makefile target This addition supports Makefile changes introduced to pulumi-docker in pulumi/pulumi-docker#479. * generalize approach to denote a hybrid provider rather than docekr specifically * Generate all providers. Updates major version for Fastly but does not add any extra targets to non-hybrid providers, as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses code similar to pulumi/pulumi-kubernetes#1999
to generate valid code blocks to use as an example for the use of the Image resource.
Fixes #406
Supersedes #440