Look up host config registry by hostname or by address #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an extra lookup with `https://` prefix to the authConfig lookup
guineveresaenger
force-pushed
the
fix-auth-config
branch
from
94755c0 to
db24b8f
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
For the bits of Flux that deal with image registries, I ended up using https://github.com/google/go-containerregistry/, which deals with all the details of authorisation from various sources, as well as listing tags, and pushing and pulling images. Much easier than docker/distribution (which the first version of Flux used -- it sucked getting that to work). |
|
Closing as fixed via #480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For login via host auth config, we have discovered that what is stored
in the credentials location is a lookup map, which sometimes contains
the registry host name, and sometimes the registry hostname with an
https://prefix. We have not root caused this discrepancy but it seemsto be the former on Linux and the latter on MacOs.
Fixes #472.
Adds an extra lookup with
https://prefix to the authConfig lookup