Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-docker to v3.0.1 #476

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Feb 1, 2023

Fixes #458
Fixes #457
Fixes #456
Fixes #452
Fixes #447
Fixes #419

@aq17 aq17 requested review from guineveresaenger, iwahbe and a team February 1, 2023 01:49
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@AaronFriel
Copy link
Contributor

@guineveresaenger any objection to us releasing this while we keep working on v4?

@AaronFriel
Copy link
Contributor

AaronFriel commented Feb 1, 2023

Actually, interesting question, this is a major version bump. That makes "v4" into "v5".

@guineveresaenger
Copy link
Contributor

I think it makes sense to merge this, but hold off on releasing our major version. Especially since there's not really any breaking schema changes.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge but do not cut a release yet!

@aq17 aq17 merged commit 38830b1 into master Feb 1, 2023
@aq17 aq17 deleted the aqiu/upgrade-v3.0.1 branch February 1, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants