Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable examples tests against Docker Image v4, fix push auth #473

Closed
wants to merge 5 commits into from
Closed

Enable examples tests against Docker Image v4, fix push auth #473

wants to merge 5 commits into from

Conversation

AaronFriel
Copy link
Contributor

@AaronFriel AaronFriel commented Jan 28, 2023 •
edited
Loading

This uses an approach proven out in a PR to pulumi-keycloak to enable examples tests to run against the local build:

This series of commits:

  1. Updates the Go examples to run against the local sdk, removing test skips
  2. Modifies push config auth to trim https:// off of server addresses
  3. Modifies the docker build caching test to validate CacheFrom behavior

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@AaronFriel
Copy link
Contributor Author

I expect some tests to fail, will look at this on Monday.

@AaronFriel AaronFriel marked this pull request as draft January 28, 2023 20:52
@AaronFriel AaronFriel force-pushed the friel/major-version-update branch from fc661a1 to faa9786 Compare January 29, 2023 01:59
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@guineveresaenger guineveresaenger mentioned this pull request Feb 13, 2023
Closed
@AaronFriel AaronFriel force-pushed the friel/major-version-update branch from faa9786 to 8fccc0b Compare March 6, 2023 10:59
@AaronFriel AaronFriel force-pushed the friel/major-version-update branch from 8fccc0b to 3688381 Compare March 6, 2023 11:00
iwahbe and others added 2 commits March 6, 2023 13:42
@iwahbe
Replace provider/shim with upstream/shim
3ec622c 
This simplifies the number of pulumi modifications to the standard build process. Our
automatic upgrade tools don't know how to deal with a provider that is both shimmed and
patched.
@AaronFriel
Merge pull request #516 from pulumi/iwahbe/remove-shim-trick
8663622 
Remove shim trick
@guineveresaenger guineveresaenger mentioned this pull request Mar 7, 2023
Merged
@AaronFriel AaronFriel mentioned this pull request Mar 7, 2023
Closed
@AaronFriel AaronFriel closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronFriel @iwahbe