Add Unit Tests for Input Parsing #433
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
provider/image.go
Outdated
| return reg | ||
| } | ||
| return reg | ||
| } | ||
|
|
||
| func setArgs(a resource.PropertyValue) map[string]*string { |
There was a problem hiding this comment.
Curious why these are called setX? They're pure functions that are doing some marshaling? The set prefix makes me expect they set something.
There was a problem hiding this comment.
replacing with marshalX - thank you that is a good point!
provider/image_test.go
Outdated
| input := resource.PropertyValue{ | ||
| resource.NewPropertyMapFromMap(map[string]interface{}{}), | ||
| } | ||
| actual := marshalBuild(input) |
There was a problem hiding this comment.
Clearly from this test it looks like marshalBuild applies default values. This is a bit unexpected given the name "marshalBuild" the "marshal" part makes me expect something that just does 'boring' conversions between formats. Perhaps "marshalBuildAndApplyDefaults"?
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
This PR cleans up the input verification for Image and adds unit tests.
There are a few minor code changes mostly as a result of adding test cases.
Fixes #420