Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing await statement in docker.Image Python implementation. #408

Closed
wants to merge 1 commit into from

Conversation

jkodroff
Copy link
Member

Fixes #366

Note that I eyeballed this code. I was not able to consistently reproduce, but based on reading the code and my intermediate understanding of Python, every async function should be called with await.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

Hello and thank you for your pull request! ❤️ ✨
It looks like you're directly modifying files in the language SDKs, many of which are autogenerated.
Be sure any files you're editing do not begin with a code generation warning.
For generated files, you will need to make changes in resources.go instead, and generate the code.

@guineveresaenger
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

@briandestura
Copy link

Hello @guineveresaenger @jkodroff Was wondering if there are any updates on this?

@guineveresaenger
Copy link
Contributor

Hi everyone!

Unfortunately, it appears as though this does not persistently fix the underlying issue.

We do have efforts underway to address this and other issues more robustly, so I will be closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using pull_cache method
4 participants