Improve build and push output #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes a variety of improvements to the log output of the build and push steps, both for cross-language consistency, and for a more focused and useful default display. Improvements include: * Significantly reduce the diagnostic-level output - render just start/end notes for build and push steps - plus streamed output from docker build and docker push. * Keep diagnostic logs as "debug" level logs * Correctly stream stdout to emphemeral logs for Go * Fix incorrect newline handling of streamed stdout in Node.js * Add tests of CLI output
stack72
reviewed
Dec 30, 2020
stack72
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a variety of improvements to the log output of the build and push steps, both for cross-language consistency, and for a more focused and useful default display.
Improvements include: