consistently handle environment variables #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBoyle
force-pushed
the
evan/fixEnvVars
branch
from
af290ca to
7e2ff61
Compare
EvanBoyle
force-pushed
the
evan/fixEnvVars
branch
from
7e2ff61 to
e4ad780
Compare
stack72
suggested changes
Sep 4, 2020
| @@ -82,7 +82,7 @@ type DockerBuildArgs struct { | |||
| // An optional map of named build-time argument variables to set during the Docker build. | |||
| // This flag allows you to pass built-time variables that can be accessed like environment variables | |||
| // inside the `RUN` instruction. | |||
| Args pulumi.MapInput `pulumi:"args"` | |||
| Args pulumi.StringMap `pulumi:"args"` | |||
There was a problem hiding this comment.
Is this a breaking change? Users will need to update their code right?
There was a problem hiding this comment.
This is mentioned in the PR description. Args and Env don't work as implemented. There's a panic unmarshalling to the wrong type.
jaxxstorm
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that any environment variables passed in are appended to the current OS env vars. Adds tests to document behavior across languages.
Fixes #196
Note: there is a breaking change for go types for Args and Env, but this is in the category of "never worked in the first place". The unmarshalling fails when you specify environment variables as is, so this change to types just makes it work as intended.