Check that docker is available earlier in the Image creation #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
force-pushed
the
stack72/gh-88
branch
from
f9f4193 to
827635e
Compare
| @@ -129,6 +129,8 @@ public Image(string name, ImageArgs args, ComponentResourceOptions? options = nu | |||
| { | |||
| var imageName = imageArgs.Item1; | |||
|
|
|||
| Docker.RunCommandThatMustSucceed("docker", new[] { "ps"}, this).ConfigureAwait(false); | |||
There was a problem hiding this comment.
Why will this run fundamentally earlier than BuildAndPushImage several lines down below?
| @@ -540,7 +540,7 @@ async Task doTagAndPushAsync(string targetName) | |||
| /// when an error happens. In general reporting the full command line is fine. But it should be set | |||
| /// to false if it might contain sensitive information (like a username/password) | |||
| /// </summary> | |||
| private static async Task<string> RunCommandThatMustSucceed( | |||
| public static async Task<string> RunCommandThatMustSucceed( | |||
There was a problem hiding this comment.
Suggested change
| public static async Task<string> RunCommandThatMustSucceed( | |
| internal static async Task<string> RunCommandThatMustSucceed( |
|
Closing this out - we will address this in a different way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #88