Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random build ID #1225

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Remove random build ID #1225

merged 2 commits into from
Sep 19, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Sep 5, 2024

This ID was added for diagnostics and we haven't seen any warnings reported so it should be safe to remove. More importantly the presence of the random label causes perpetual diffs, which is undesirable.

Fixes #1219
Fixes #1224
Refs #846

Copy link

github-actions bot commented Sep 5, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, apologies for letting this sit! this LGTM.

@blampe blampe merged commit 96b658d into master Sep 19, 2024
23 checks passed
@blampe blampe deleted the blampe/build-id branch September 19, 2024 00:02
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v4.5.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: master New build-id label results in unique digests on each build
3 participants