Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example #1152

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fix example #1152

merged 3 commits into from
Jun 24, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Jun 20, 2024

Fixes the example (thanks @MitchellGerdisch!) and adds a note pointing to the new Docker Build provider.

Fixes #1150.

@blampe blampe requested a review from MitchellGerdisch June 20, 2024 18:12
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@blampe
Copy link
Contributor Author

blampe commented Jun 20, 2024

Tests seem to be failing due to pulumi/pulumi-azure#2136.

@blampe blampe added the area/docs Improvements or additions to documentation label Jun 24, 2024
@blampe blampe requested a review from a team June 24, 2024 23:04
@blampe blampe merged commit c2158bc into master Jun 24, 2024
18 checks passed
@blampe blampe deleted the blampe/example branch June 24, 2024 23:22
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v4.5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Example for ecr push has some mistakes
3 participants