Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream v5.72.0 #4647

Merged
merged 20 commits into from
Oct 28, 2024
Merged

Upstream v5.72.0 #4647

merged 20 commits into from
Oct 28, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Oct 16, 2024 •
edited
Loading

Upgrades upstream to v5.72.0

New resources:

  • iam/rolePolicyAttachmentsExclusive.RolePolicyAttachmentsExclusive

In this release upstream has introduced deprecations for AWS IAM Role managed_policy_arns arguments. These deprecations are not yet propagated into the Pulumi provider (#4654 tracks the context).

Fixes #4642

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Does the PR have any schema changes?

Found 1 breaking change:

Types

  • 🟡 "aws:workspaces/ConnectionAliasTimeouts:ConnectionAliasTimeouts": properties: "update" missing

New resources:

  • iam/rolePolicyAttachmentsExclusive.RolePolicyAttachmentsExclusive

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 16, 2024 

      /**
  +     * Set of exclusive IAM managed policy ARNs to attach to the IAM role. If this attribute is not configured, Pulumi will ignore policy attachments to this resource. When configured, Pulumi will align the role's managed policy attachments with this set by attaching or detaching managed policies. Configuring an empty set (i.e., `managedPolicyArns = []`) will cause Pulumi to remove _all_ managed policy attachments.
  +     *
        * @deprecated The managedPolicyArns argument is deprecated. Use the aws.iam.RolePolicyAttachmentsExclusive resource instead.
        */

There's new deprecations rolling out, need to double-check this.

flostadler
flostadler approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t0yv0 t0yv0 mentioned this pull request Oct 17, 2024
Closed
@t0yv0 t0yv0 marked this pull request as ready for review October 25, 2024 17:37
@t0yv0 t0yv0 requested a review from corymhall October 25, 2024 17:37
flostadler
flostadler reviewed Oct 25, 2024
View reviewed changes
patches/0070-Temporarily-undo-aws.iam.Role-managed_policy_arns-an.patch Outdated
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Anton Tayanovskyy <[email protected]>
Date: Fri, 25 Oct 2024 13:17:15 -0400
Subject: [PATCH] Temporarily undo aws.iam.Role managed_policy_arns and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have a ticket for tracking how we wanna tackle this long term?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. #4654 tracks figuring this out as soon as time permits.

provider/replacements.json Outdated Show resolved Hide resolved
@t0yv0 t0yv0 enabled auto-merge (squash) October 25, 2024 18:24
@t0yv0 t0yv0 disabled auto-merge October 25, 2024 18:49
@t0yv0 t0yv0 enabled auto-merge (squash) October 25, 2024 19:34
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 26, 2024

My hope is that it should go in after #4673 as the failing test started failing independently. This should not release though as subsequent upstream release fixes some immediate bugs.

@t0yv0 t0yv0 merged commit 0e5b91d into master Oct 28, 2024
33 checks passed
@t0yv0 t0yv0 deleted the upstream-v5.72.0 branch October 28, 2024 15:13
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.57.0.

@pulumi-bot pulumi-bot mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

@flostadler flostadler flostadler approved these changes

Assignees

@t0yv0 t0yv0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.72.0
4 participants
@t0yv0 @pulumi-bot @flostadler @corymhall