Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream v5.53.0 #4055

Merged
merged 9 commits into from
Jun 12, 2024
Merged

upstream v5.53.0 #4055

merged 9 commits into from
Jun 12, 2024

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented Jun 11, 2024

  • Moving ./upstream to v5.53.0
  • Update patches
  • ./scripts/tidy-all.sh
  • Fix tags_all Computed for PF resources
  • Add module mapping for AWS Payment Cryptography
  • Regenerate schema
  • Regenerate sdk

Fixes #4044
Fixes #4017 (The underlying issue of this patch was fixed as part of v5.53.0 hashicorp/terraform-provider-aws#37812)

@flostadler flostadler self-assigned this Jun 11, 2024
@@ -44,25 +45,34 @@ index 0000000000..54f6aac15a
+ })
+ return lambda_sdkv2.NewFromConfig(cfg, func(o *lambda_sdkv2.Options) {
+ if endpoint := config[names.AttrEndpoint].(string); endpoint != "" {
+ tflog.Debug(ctx, "setting endpoint", map[string]any{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change comes from this upstream PR: https://github.com/hashicorp/terraform-provider-aws/pull/34233/files#diff-9c93e6008819246a3298682bf745457767b75aad2ce53cd024233e30253b4c9cR165

Custom endpoints can now override the use_fips_endpoint flag for individual services

Copy link

Does the PR have any schema changes?

Found 2 breaking changes:

Resources

  • 🟢 "aws:ec2/customerGateway:CustomerGateway": required: "bgpAsn" property is no longer Required

Types

  • 🟢 "aws:pipes/PipeSourceParametersSelfManagedKafkaParametersCredentials:PipeSourceParametersSelfManagedKafkaParametersCredentials": required: "basicAuth" property is no longer Required

New resources:

  • paymentcryptography/key.Key
  • paymentcryptography/keyAlias.KeyAlias

Maintainer note: consult the runbook for dealing with any breaking changes.

@flostadler flostadler requested review from a team, t0yv0 and corymhall June 11, 2024 16:07
@flostadler
Copy link
Contributor Author

/release minor

@github-actions github-actions bot added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Jun 11, 2024
@flostadler flostadler merged commit a586abd into master Jun 12, 2024
24 checks passed
@flostadler flostadler deleted the upstream-v5.53.0 branch June 12, 2024 06:34
@iwahbe
Copy link
Member

iwahbe commented Jun 12, 2024

@flostadler FYI: You can just add the needs-release/minor label manually and it works the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0
Projects
None yet
2 participants