Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions workflows. #3938

Merged
merged 1 commit into from
May 14, 2024

Conversation

pulumi-bot
Copy link
Contributor

This PR was automatically generated by the update-workflows-single-bridged-provider workflow in the pulumi/ci-mgmt repo, from commit c34e73d55a9ea7e72ec250dd792b0c6b5a94cc0e.

@pulumi-bot pulumi-bot added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label May 14, 2024
@@ -126,7 +126,7 @@ install_plugins: .pulumi/bin/pulumi
.pulumi/bin/pulumi plugin install resource random 4.8.2
.pulumi/bin/pulumi plugin install resource github 5.14.0
.pulumi/bin/pulumi plugin install resource std 1.6.2
.pulumi/bin/pulumi plugin install converter terraform 1.0.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change might be causing the diff in the descriptions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, since this is what we use to generate code examples.

@danielrbradley danielrbradley requested review from iwahbe May 14, 2024 14:06
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, getting a second opinion from @iwahbe

  • All workflow & version changes look as expected.
  • Descriptions looks like an improvement too, though come from another change rather than my ci-mgmt PR.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@danielrbradley danielrbradley merged commit 5d36c9b into master May 14, 2024
24 checks passed
@danielrbradley danielrbradley deleted the update-github-actions-workflows-348 branch May 14, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants