fix: sns topic creation fails in non-standard partitions #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the AWS partition dynamically instead of hardcoding the default `aws` partition. I'm not sure there is a good way to test this since we do not have credentials for other partitions fixes #3926
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Yeah they are specialty partitions. We plan to use this as soon as it merges. Hoping to avoid having to compile Pulumi from source to test this if that's what you're waiting on. Generally speaking, if you're using the https://docs.aws.amazon.com/IAM/latest/UserGuide/reference-arns.html |
|
Thank you! |
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
May 19, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.35.0` -> `6.36.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.35.0/6.36.0) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.36.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.36.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.35.0...v6.36.0) ##### What's Changed - upstream v5.49.0 by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/3936](https://togithub.com/pulumi/pulumi-aws/pull/3936) - fix: sns topic creation fails in non-standard partitions by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/3932](https://togithub.com/pulumi/pulumi-aws/pull/3932) - fix: wafv2 permanent diff issues ([#​3880](https://togithub.com/pulumi/pulumi-aws/issues/3880) [#​3306](https://togithub.com/pulumi/pulumi-aws/issues/3306) [#​3190](https://togithub.com/pulumi/pulumi-aws/issues/3190) [#​3454](https://togithub.com/pulumi/pulumi-aws/issues/3454)) - Enroll aws_wafv2\_rule_group in PlanResourceChange by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/3948](https://togithub.com/pulumi/pulumi-aws/pull/3948) - Upgrade pulumi-terraform-bridge to v3.82.0 by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/3929](https://togithub.com/pulumi/pulumi-aws/pull/3929) - Dependencies: terraform converter v1.0.17 by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3923](https://togithub.com/pulumi/pulumi-aws/pull/3923) **Full Changelog**: pulumi/pulumi-aws@v6.35.0...v6.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
May 19, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.35.0` -> `6.36.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.35.0/6.36.0) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.36.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.36.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.35.0...v6.36.0) ##### What's Changed - upstream v5.49.0 by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/3936](https://togithub.com/pulumi/pulumi-aws/pull/3936) - fix: sns topic creation fails in non-standard partitions by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/3932](https://togithub.com/pulumi/pulumi-aws/pull/3932) - fix: wafv2 permanent diff issues ([#​3880](https://togithub.com/pulumi/pulumi-aws/issues/3880) [#​3306](https://togithub.com/pulumi/pulumi-aws/issues/3306) [#​3190](https://togithub.com/pulumi/pulumi-aws/issues/3190) [#​3454](https://togithub.com/pulumi/pulumi-aws/issues/3454)) - Enroll aws_wafv2\_rule_group in PlanResourceChange by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/3948](https://togithub.com/pulumi/pulumi-aws/pull/3948) - Upgrade pulumi-terraform-bridge to v3.82.0 by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/3929](https://togithub.com/pulumi/pulumi-aws/pull/3929) - Dependencies: terraform converter v1.0.17 by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/3923](https://togithub.com/pulumi/pulumi-aws/pull/3923) **Full Changelog**: pulumi/pulumi-aws@v6.35.0...v6.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the AWS partition dynamically instead of hardcoding the default
awspartition.I'm not sure there is a good way to test this since we do not have credentials for other partitions
fixes #3926