Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check worktree clean does not detect diffs in the SDKs for missing files #1827

Closed
flostadler opened this issue Nov 14, 2024 · 0 comments · Fixed by #1887
Closed

Check worktree clean does not detect diffs in the SDKs for missing files #1827

flostadler opened this issue Nov 14, 2024 · 0 comments · Fixed by #1887
Assignees
@corymhall
Labels
impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.114

Comments

@flostadler
Copy link
Contributor

If a file is missing from the sdk folder, the Check worktree clean action does not detect the diff. This is because we're deleting files not tracked in git before running the Check worktree clean action:

pulumi-aws-native/Makefile

Line 116 in 4872ad6

cd sdk/python/ && git clean -fxd

This can cause issues like: #1826 where the python SDK is broken due to missing files.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 14, 2024
@flostadler flostadler added kind/engineering Work that is not visible to an external user impact/reliability Something that feels unreliable or flaky and removed needs-triage Needs attention from the triage team labels Nov 14, 2024
@flostadler flostadler mentioned this issue Nov 14, 2024
Closed
@mjeffryes mjeffryes added this to the 0.114 milestone Dec 3, 2024
corymhall added a commit that referenced this issue Dec 4, 2024
@corymhall
chore: do not clean untracked files
3e69cb6 
I don't know why we were running `git clean` here, but we don't do that
in any other providers. This is preventing our check worktree clean job
to correctly catch when new sdk files are not checked in.

fixes #1827
@corymhall corymhall mentioned this issue Dec 4, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.114
Development

Successfully merging a pull request may close this issue.

chore: do not clean untracked files pulumi/pulumi-aws-native
4 participants
@mjeffryes @flostadler @pulumi-bot @corymhall