Prepare for v1.5.2 release #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously not nesting maps of arrays, and treating them as generic types instead. This is an issue in Golang codegen, generating generic Pulumi input/output types that don't exists. This commit ensures we also flatten map of arrays so Golang codegen works. Fixes: #147
rquitales
force-pushed
the
rquitales/update-p-k
branch
from
417e9b8 to
94cbd27
Compare
blampe
approved these changes
Sep 16, 2024
rquitales
force-pushed
the
rquitales/update-p-k
branch
from
94cbd27 to
92dc921
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 78.10% 78.34% +0.23%
==========================================
Files 17 17
Lines 708 725 +17
==========================================
+ Hits 553 568 +15
- Misses 87 88 +1
- Partials 68 69 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 changes/commits and is intended to be rebased and merged to maintain commit history.
Changes made:
master.Related Issues:
Resolves: #147, resolves #148