Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulumi-kubernetes workflows to use kind and free up disk space #846

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

@rquitales rquitales requested review from a team and mjeffryes March 13, 2024 00:20
@rquitales rquitales marked this pull request as draft March 13, 2024 00:22
@rquitales
Copy link
Member Author

Ah, need to update the TypeScript source, not the generated workflow.

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just ship the kind changes, since the disk space work is already in ci-mgmt.

Comment on lines 422 to 423
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note this is already in the workflow at line 394. (I added to ci-mgmt, and was just going to wait for it to propagate.)

@rquitales rquitales force-pushed the rquitales/kubernetes-improvements branch from e27c995 to c073a81 Compare March 13, 2024 18:02
@rquitales rquitales marked this pull request as ready for review March 13, 2024 18:03
@rquitales
Copy link
Member Author

Please just ship the kind changes, since the disk space work is already in ci-mgmt.

I've added a hotfix for the disk space work in this PR. The build job is still failing in kubernetes (and other native providers that use ci-mgmt as well) since the jlumbroso/free-disk-space action does not support major version tagging. This PR fixes the action to the latest release.

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rquitales rquitales merged commit 45d2820 into master Mar 13, 2024
4 checks passed
@rquitales rquitales deleted the rquitales/kubernetes-improvements branch March 13, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: build
2 participants