Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update cva6 to pulp-v1.0.0 #99

Merged
merged 4 commits into from
Feb 28, 2024
Merged

deps: Update cva6 to pulp-v1.0.0 #99

merged 4 commits into from
Feb 28, 2024

Conversation

niwis
Copy link
Contributor

@niwis niwis commented Feb 9, 2024

Bump pulp-v1 of CVA6 with many updates and improvements.

ToDo:

  • Draft pulp-v1 integration
  • Fix existing regression tests
  • Add new regression tests targeting H ext, CLIC

@niwis niwis changed the title cva6: Bump pulp-v1 deps: Update cva6 to pulp-v1.0.0 Feb 9, 2024
@niwis niwis force-pushed the nw/cva6-pulp-v1 branch 2 times, most recently from 2116687 to 9908c92 Compare February 9, 2024 22:07
@alex96295 alex96295 added the enhancement New feature or request label Feb 14, 2024
@niwis niwis force-pushed the nw/cva6-pulp-v1 branch 2 times, most recently from 0ef0655 to 0d1a29a Compare February 24, 2024 07:20
@niwis niwis marked this pull request as ready for review February 25, 2024 21:23
@niwis niwis requested a review from paulsc96 February 25, 2024 21:23
paulsc96
paulsc96 previously approved these changes Feb 27, 2024
Copy link
Collaborator

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring a few comments below, LGTM.

The only question is if we can derive the CVA6 parameters from defaults. This is not strictly necessary, but duplicates defaults always make me a bit nervous.

hw/cheshire_pkg.sv Outdated Show resolved Hide resolved
hw/cheshire_pkg.sv Outdated Show resolved Hide resolved
@paulsc96 paulsc96 merged commit 4635eb4 into main Feb 28, 2024
18 checks passed
@paulsc96 paulsc96 deleted the nw/cva6-pulp-v1 branch February 28, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants