-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update cva6
to pulp-v1.0.0
#99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niwis
force-pushed
the
nw/cva6-pulp-v1
branch
from
February 9, 2024 14:02
91eea80
to
18d75fb
Compare
niwis
force-pushed
the
nw/cva6-pulp-v1
branch
2 times, most recently
from
February 9, 2024 22:07
2116687
to
9908c92
Compare
niwis
force-pushed
the
nw/cva6-pulp-v1
branch
2 times, most recently
from
February 24, 2024 07:20
0ef0655
to
0d1a29a
Compare
Signed-off-by: Nils Wistoff <[email protected]>
Signed-off-by: Nils Wistoff <[email protected]>
niwis
force-pushed
the
nw/cva6-pulp-v1
branch
from
February 25, 2024 21:22
0d1a29a
to
3cc5c60
Compare
paulsc96
previously approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Barring a few comments below, LGTM.
The only question is if we can derive the CVA6 parameters from defaults. This is not strictly necessary, but duplicates defaults always make me a bit nervous.
Signed-off-by: Nils Wistoff <[email protected]>
Signed-off-by: Nils Wistoff <[email protected]>
paulsc96
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump pulp-v1 of CVA6 with many updates and improvements.
ToDo: