Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPGAs changes and fixup, ethernet, pcie, constraints #261

Merged
merged 3 commits into from
Jun 5, 2024
Merged

FPGAs changes and fixup, ethernet, pcie, constraints #261

merged 3 commits into from
Jun 5, 2024

Conversation

CyrilKoe
Copy link
Contributor

@CyrilKoe CyrilKoe commented Mar 19, 2024 •
edited
Loading

Changes:

  • Re-wired properly the JTAG chain on island disable
  • Added the safety + spatz config
  • Corrected pulp cluster CDC constraints
  • Modified device tree structure to have a new PCIe top level dts
  • Modified PCIe ranges in block design
  • Added reconfigurable MAC address and ethernet boot image path
  • Added CVA6-sdk as a subrepo as in Cheshire
  • Modified CI accordingly (please see PR) (auto select available board + remote boot possible)

Status:

@CyrilKoe CyrilKoe requested a review from alex96295 as a code owner March 19, 2024 16:16
@CyrilKoe CyrilKoe self-assigned this Mar 19, 2024
@CyrilKoe CyrilKoe requested a review from yvantor March 19, 2024 16:17
@CyrilKoe CyrilKoe changed the title FPGAs changes and fixup, ethernet, pcie, constraints Draft: FPGAs changes and fixup, ethernet, pcie, constraints Mar 19, 2024
@CyrilKoe CyrilKoe marked this pull request as draft March 19, 2024 16:17
@CyrilKoe CyrilKoe force-pushed the ck/fpga_fixes branch 10 times, most recently from 276bf0f to e468512 Compare March 21, 2024 13:33
@CyrilKoe CyrilKoe force-pushed the ck/fpga_fixes branch 2 times, most recently from 2ab8263 to 29e11d8 Compare April 3, 2024 12:05
@CyrilKoe CyrilKoe force-pushed the ck/fpga_fixes branch 6 times, most recently from ba4b8c9 to 308fd73 Compare April 21, 2024 08:59
yvantor
yvantor reviewed Apr 21, 2024
View reviewed changes
Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the CVA6-SDK, overall I did not spot anything proud of notice. One question, I see you have added a DTS for booting on VCU118 and also made some of the scripts more "agnostic" towards the kind of board. Do you think it would make sense to also merge in this branch the changes to support the VCU118?

sw/deps/cva6-sdk Outdated Show resolved Hide resolved
@CyrilKoe CyrilKoe force-pushed the ck/fpga_fixes branch 2 times, most recently from a3743c5 to 141880c Compare April 22, 2024 13:12
@CyrilKoe
fpga: Correct pulp island CDC constraints
7b36cca 
safety_island: Point towards ck/omptarget

spatz: Point towards ck/spatz-carfield

fpga: Select mac_addr by env variable

hero: Device tree update

safety_island: Update commit

spatz: Update commit

fpga: Add safety+spatz config and jtag chain

misc: Fixups
@CyrilKoe CyrilKoe changed the title Draft: FPGAs changes and fixup, ethernet, pcie, constraints FPGAs changes and fixup, ethernet, pcie, constraints Apr 22, 2024
@CyrilKoe
Copy link
Contributor Author

Just one comment on the CVA6-SDK, overall I did not spot anything proud of notice. One question, I see you have added a DTS for booting on VCU118 and also made some of the scripts more "agnostic" towards the kind of board. Do you think it would make sense to also merge in this branch the changes to support the VCU118?

I removed it, it will be part of the next PR

@CyrilKoe CyrilKoe marked this pull request as ready for review April 22, 2024 17:48
@CyrilKoe
Copy link
Contributor Author

@yvantor or @alex96295 this is now ready for review

@CyrilKoe
Copy link
Contributor Author

CI failed due to limited disk space, restarted it this morning

@CyrilKoe
Copy link
Contributor Author

What do you think @yvantor @alex96295 ?

yvantor
yvantor approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I confirm my previous comment, I do not have particular concerns. Approved!

@alex96295
Copy link
Collaborator

Thanks! I will review it next week

alex96295
alex96295 reviewed May 28, 2024
View reviewed changes
carfield.mk Outdated Show resolved Hide resolved
alex96295
alex96295 approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@alex96295 alex96295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very small comment, for the rest LGTM; thanks for the work

@CyrilKoe CyrilKoe merged commit cb357a4 into main Jun 5, 2024
7 checks passed
@CyrilKoe CyrilKoe deleted the ck/fpga_fixes branch June 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex96295 alex96295 alex96295 approved these changes

@yvantor yvantor yvantor approved these changes

Assignees

@CyrilKoe CyrilKoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrilKoe @alex96295 @yvantor