-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
floogen: Add support for installation within python virtual environment #81
Open
gbellocchi
wants to merge
1
commit into
main
Choose a base branch
from
floogen-venv-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# Copyright 2023 University of Modena and Reggio Emilia. | ||
# Licensed under the Apache License, Version 2.0, see LICENSE for details. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# | ||
# Author: Gianluca Bellocchi <[email protected]> | ||
|
||
#!/bin/bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shebang should be the first line before the license header |
||
|
||
FLOOGEN_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | ||
FLOOGEN_VENV_NAME=floogen # should match name specified in pyproject.toml | ||
|
||
POETRY='poetry@main' # temporary | ||
|
||
ENV_LIST=$($POETRY env list) | ||
ENV_PATH=$($POETRY env info --path) | ||
|
||
# check if previous floogen virtual environment exists | ||
echo "$ENV_LIST" | grep "venv" &> /dev/null | ||
if [ $? == 0 ]; then | ||
Comment on lines
+18
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't poetry automatically check if there is already a python environment? |
||
echo "Old $FLOOGEN_VENV_NAME virtual environment exists" | ||
echo "$ENV_PATH" | ||
echo "Do you want to proceed and install $FLOOGEN_VENV_NAME again?" | ||
|
||
select yn in "yes" "no"; do | ||
case $yn in | ||
yes ) break;; | ||
no ) exit;; | ||
esac | ||
done | ||
fi | ||
|
||
# check if other floogen virtual environments exist | ||
echo "$ENV_LIST" | grep $FLOOGEN_VENV_NAME &> /dev/null | ||
if [ $? == 0 ]; then | ||
echo "Old $FLOOGEN_VENV_NAME virtual environment exists" | ||
echo "$ENV_PATH" | ||
echo "Do you want to proceed and install $FLOOGEN_VENV_NAME again?" | ||
|
||
select yn in "yes" "no"; do | ||
case $yn in | ||
yes ) break;; | ||
no ) exit;; | ||
esac | ||
done | ||
fi | ||
|
||
# install environment (does not update lock if it exists) | ||
echo "Installing $FLOOGEN_VENV_NAME virtual environment" | ||
$POETRY install --sync | ||
|
||
# to activate environment | ||
if [[ "$VIRTUAL_ENV" == "" ]] | ||
then | ||
echo "Activating $FLOOGEN_VENV_NAME virtual environment" | ||
$POETRY shell | ||
fi |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter will not like your university😉 You will have to use the ETH/Bologna header to pass the CI