Added public/public folder to gitignore

[imajit]

Added public/public folder to gitignore

[gitpod-io]

[codeclimate]

Code Climate has analyzed commit 82dd491 and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #9982 (53745b3) into main (f41f8e7) will increase coverage by 0.11%.
The diff coverage is 90.90%.

❗ Current head 53745b3 differs from pull request most recent head 82dd491. Consider uploading reports for the commit 82dd491 to get more accurate results

@@            Coverage Diff             @@
##             main    #9982      +/-   ##
==========================================
+ Coverage   82.13%   82.24%   +0.11%     
==========================================
  Files          98       98              
  Lines        5968     5966       -2     
==========================================
+ Hits         4902     4907       +5     
+ Misses       1066     1059       -7     

Impacted Files	Coverage Δ
app/helpers/application_helper.rb	85.41% <50.00%> (ø)
app/controllers/images_controller.rb	70.27% <100.00%> (ø)
app/services/search_service.rb	95.00% <100.00%> (-0.10%)	⬇️
app/api/srch/search.rb	70.70% <0.00%> (+3.82%)	⬆️
app/services/execute_search.rb	94.44% <0.00%> (+5.55%)	⬆️

[noi5e]

Looks fine to me.

Why are we making this change again? :) I don't seem to have a public/public folder locally:

I think I remember seeing something about this on chat or GitHub. Is there an issue open that we can link to here so that we can get some good documentation?

[imajit]

Looks fine to me.

Why are we making this change again? :) I don't seem to have a public/public folder locally:

I think I remember seeing something about this on chat or GitHub. Is there an issue open that we can link to here so that we can get some good documentation?

Hi!
This folder was created when I ran system tests recently. It has some screenshots. I'm not sure if its an issue specific to my system. @noi5e Can if verify this in your system? I will close the PR if it's just a local issue.

[noi5e]

This folder was created when I ran system tests recently. It has some screenshots. I'm not sure if its an issue specific to my system. @noi5e Can if verify this in your system? I will close the PR if it's just a local issue.

Hmm, yeah, I don't see it on my main branch. Let's leave this open for now. I'll request review from @Tlazypanda and @jywarren, maybe they have seen it locally

[noi5e]

Even though no one else weighed in, I'm going to go ahead and merge this one to clear the PRs.

It's small enough it can be easily reverted, and I'm sure it will help if there are other people experiencing this! Thanks @imajit

[jywarren]

Thanks @imajit @noi5e -- much appreciated!