-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update about us #9937
Update about us #9937
Conversation
added a menu item for future wiki page "careers" to be added to the "About Us" dropdown menu.
updated the new wiki page name
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 60430f4 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9937 +/- ##
==========================================
- Coverage 82.24% 82.13% -0.11%
==========================================
Files 98 98
Lines 5964 5968 +4
==========================================
- Hits 4905 4902 -3
- Misses 1059 1066 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great thanks!
Do you know when this will go to stable, and then to production?
|
It should be on stable as soon as someone with authorization pushes the |
* Update _header.html.erb added a menu item for future wiki page "careers" to be added to the "About Us" dropdown menu. * Update _header.html.erb updated the new wiki page name
* Update _header.html.erb added a menu item for future wiki page "careers" to be added to the "About Us" dropdown menu. * Update _header.html.erb updated the new wiki page name
Hi all, this PR does not have the boxes checked, can it still be reviewed?
It adds one link to the About Us dropdown in coordination with the nonprofit.
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!