Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about us #9937

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Update about us #9937

merged 2 commits into from
Jul 22, 2021

Conversation

ebarry
Copy link
Member

@ebarry ebarry commented Jul 21, 2021

Hi all, this PR does not have the boxes checked, can it still be reviewed?
It adds one link to the About Us dropdown in coordination with the nonprofit.

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

ebarry added 2 commits July 20, 2021 15:24
added a menu item for future wiki page "careers" to be added to the "About Us" dropdown menu.
updated the new wiki page name
@ebarry ebarry requested a review from a team as a code owner July 21, 2021 19:36
@welcome
Copy link

welcome bot commented Jul 21, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2021

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2021

Code Climate has analyzed commit 60430f4 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #9937 (60430f4) into main (fb894e3) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9937      +/-   ##
==========================================
- Coverage   82.24%   82.13%   -0.11%     
==========================================
  Files          98       98              
  Lines        5964     5968       +4     
==========================================
- Hits         4905     4902       -3     
- Misses       1059     1066       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️
app/models/concerns/comments_shared.rb 92.00% <0.00%> (+1.52%) ⬆️

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Seems to be working great 🚀

@ebarry
Copy link
Member Author

ebarry commented Jul 21, 2021 via email

@daemon1024
Copy link
Member

It should be on stable as soon as someone with authorization pushes the Merge Button. For the production, I am not sure about it but it's usually within a week or two after it's pushed to stable.

@jywarren jywarren merged commit b73594f into main Jul 22, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Update _header.html.erb

added a menu item for future wiki page "careers" to be added to the "About Us" dropdown menu.

* Update _header.html.erb

updated the new wiki page name
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Update _header.html.erb

added a menu item for future wiki page "careers" to be added to the "About Us" dropdown menu.

* Update _header.html.erb

updated the new wiki page name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants