Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save system test screenshots in GitHub Actions #9868

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

jywarren
Copy link
Member

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jun 29, 2021

@codeclimate
Copy link

codeclimate bot commented Jun 29, 2021

Code Climate has analyzed commit f8303e3 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@4756f69). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d4ccb72 differs from pull request most recent head f8303e3. Consider uploading reports for the commit f8303e3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9868   +/-   ##
=======================================
  Coverage        ?   49.13%           
=======================================
  Files           ?       98           
  Lines           ?     6122           
  Branches        ?        0           
=======================================
  Hits            ?     3008           
  Misses          ?     3114           
  Partials        ?        0           

@jywarren
Copy link
Member Author

Yay!

image

image

test_signup_modal_disabled_submit_button_on_empty_username

@jywarren jywarren merged commit 6b4946f into main Jun 29, 2021
@jywarren jywarren changed the title Try saving system test screenshots in GitHub Actions Save system test screenshots in GitHub Actions Jun 29, 2021
17sushmita pushed a commit to 17sushmita/plots2 that referenced this pull request Jul 7, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant