Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated node.rb #9819

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Updated node.rb #9819

merged 1 commit into from
Jun 20, 2021

Conversation

Shashwat545
Copy link
Contributor

@Shashwat545 Shashwat545 commented Jun 16, 2021

Fixes #9779

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2021

@@ -1064,7 +1064,7 @@ def can_tag(tagname, user, errors = false)
errors ? I18n.t('node.only_RSVP_for_yourself') : false
elsif tagname == 'locked' && user.role != 'admin'
errors ? I18n.t('node.only_admins_can_lock') : false
elsif tagname == 'blog' && user.role != 'admin' && user.role != 'moderator'
elsif tagname == 'blog' && user.basic_user?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid deeply nested control flow statements.

@codeclimate
Copy link

codeclimate bot commented Jun 16, 2021

Code Climate has analyzed commit c0e1eb9 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@cesswairimu
Copy link
Collaborator

Hi @Shashwat545 , this is looking good . thanks

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@596ff0c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9819   +/-   ##
=======================================
  Coverage        ?   82.07%           
=======================================
  Files           ?       98           
  Lines           ?     5940           
  Branches        ?        0           
=======================================
  Hits            ?     4875           
  Misses          ?     1065           
  Partials        ?        0           

@Shashwat545
Copy link
Contributor Author

Hi @Shashwat545 , this is looking good . thanks

Thanks a lot for giving the opportunity. Looking forward to contribute more to open source.

Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Shashwat545 🎉

@RuthNjeri RuthNjeri merged commit cf6f681 into publiclab:main Jun 20, 2021
@welcome
Copy link

welcome bot commented Jun 20, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use basic user check on node model
3 participants