-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated node.rb #9819
Updated node.rb #9819
Conversation
@@ -1064,7 +1064,7 @@ def can_tag(tagname, user, errors = false) | |||
errors ? I18n.t('node.only_RSVP_for_yourself') : false | |||
elsif tagname == 'locked' && user.role != 'admin' | |||
errors ? I18n.t('node.only_admins_can_lock') : false | |||
elsif tagname == 'blog' && user.role != 'admin' && user.role != 'moderator' | |||
elsif tagname == 'blog' && user.basic_user? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid deeply nested control flow statements.
Code Climate has analyzed commit c0e1eb9 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Hi @Shashwat545 , this is looking good . thanks |
Codecov Report
@@ Coverage Diff @@
## main #9819 +/- ##
=======================================
Coverage ? 82.07%
=======================================
Files ? 98
Lines ? 5940
Branches ? 0
=======================================
Hits ? 4875
Misses ? 1065
Partials ? 0 |
Thanks a lot for giving the opportunity. Looking forward to contribute more to open source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Shashwat545 🎉
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixes #9779
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!