Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded the documentation about the stable and unstable servers #9744

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

anirudhprabhakaran3
Copy link
Member

Fixes #9718 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jun 5, 2021

@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #9744 (f2d9014) into main (ec281d4) will increase coverage by 0.03%.
The diff coverage is 68.42%.

❗ Current head f2d9014 differs from pull request most recent head 6549494. Consider uploading reports for the commit 6549494 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9744      +/-   ##
==========================================
+ Coverage   49.14%   49.17%   +0.03%     
==========================================
  Files          98       98              
  Lines        6125     6129       +4     
==========================================
+ Hits         3010     3014       +4     
  Misses       3115     3115              
Impacted Files Coverage Δ
app/controllers/stats_controller.rb 21.05% <0.00%> (ø)
app/controllers/tag_controller.rb 60.24% <33.33%> (+0.61%) ⬆️
app/helpers/application_helper.rb 71.87% <66.66%> (ø)
app/models/node.rb 67.66% <100.00%> (+0.10%) ⬆️
app/models/user.rb 60.85% <100.00%> (+0.28%) ⬆️
app/models/node_tag.rb 92.59% <0.00%> (-7.41%) ⬇️

@anirudhprabhakaran3
Copy link
Member Author

Why are so many tests failing, even when I'm just making changes to docs?

@RuthNjeri RuthNjeri changed the title Expnaded the documentation about the stable and unstable servers Expanded the documentation about the stable and unstable servers Jun 9, 2021
@RuthNjeri
Copy link
Contributor

Thanks for opening this up @anirudhprabhakaran3, I can see that you have not included all the information from the issue, for example, the purpose of stable.org, where you can monitor all builds, etc...

@anirudhprabhakaran3
Copy link
Member Author

Aah yes I seem to have missed a few points. I'll add those asap.

For the builds, I've made a different subsection at the end about build status and added the jenkins link. Is that what you are referring to?

Copy link
Member

@pydevsg pydevsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this @anirudhprabhakaran3 . 😄
Make a small change as asked , rest looks great to me .

doc/TESTING.md Outdated Show resolved Hide resolved
@RuthNjeri
Copy link
Contributor

Aah yes I seem to have missed a few points. I'll add those asap.

For the builds, I've made a different subsection at the end about build status and added the jenkins link. Is that what you are referring to?

Yes, I do see the Jenkins link but the purpose of the stable site from the issue is not present yet.

@RuthNjeri
Copy link
Contributor

Hi @anirudhprabhakaran3, are you having trouble with this? We are happy to help if you need any assistance.

@anirudhprabhakaran3
Copy link
Member Author

Hello! Sorry for not being that responsive...my internet is having some issues so haven't been able to contribute much lately.

I have made a few changes and additions in the newest commit. Could you go through those once? Do I have to add anything else?

doc/TESTING.md Outdated Show resolved Hide resolved
doc/TESTING.md Outdated Show resolved Hide resolved
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made some small changes. We can make more refinements later! Thanks!

@codeclimate
Copy link

codeclimate bot commented Jun 29, 2021

Code Climate has analyzed commit 6549494 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren jywarren closed this Jun 29, 2021
@jywarren jywarren reopened this Jun 29, 2021
@jywarren jywarren merged commit 75ff949 into publiclab:main Jun 29, 2021
@jywarren
Copy link
Member

Excellent, than kyou!

17sushmita pushed a commit to 17sushmita/plots2 that referenced this pull request Jul 7, 2021
…liclab#9744)

* Expnaded the documentation about the stable and unstable servers

* Added more information to docs

* Apply suggestions from code review

Co-authored-by: Jeffrey Warren <[email protected]>
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
…liclab#9744)

* Expnaded the documentation about the stable and unstable servers

* Added more information to docs

* Apply suggestions from code review

Co-authored-by: Jeffrey Warren <[email protected]>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…liclab#9744)

* Expnaded the documentation about the stable and unstable servers

* Added more information to docs

* Apply suggestions from code review

Co-authored-by: Jeffrey Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand our documentation of stable/unstable build servers
4 participants