-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded the documentation about the stable and unstable servers #9744
Expanded the documentation about the stable and unstable servers #9744
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9744 +/- ##
==========================================
+ Coverage 49.14% 49.17% +0.03%
==========================================
Files 98 98
Lines 6125 6129 +4
==========================================
+ Hits 3010 3014 +4
Misses 3115 3115
|
Why are so many tests failing, even when I'm just making changes to docs? |
Thanks for opening this up @anirudhprabhakaran3, I can see that you have not included all the information from the issue, for example, the purpose of stable.org, where you can monitor all builds, etc... |
Aah yes I seem to have missed a few points. I'll add those asap. For the builds, I've made a different subsection at the end about build status and added the jenkins link. Is that what you are referring to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this @anirudhprabhakaran3 . 😄
Make a small change as asked , rest looks great to me .
Yes, I do see the Jenkins link but the purpose of the stable site from the issue is not present yet. |
Hi @anirudhprabhakaran3, are you having trouble with this? We are happy to help if you need any assistance. |
Hello! Sorry for not being that responsive...my internet is having some issues so haven't been able to contribute much lately. I have made a few changes and additions in the newest commit. Could you go through those once? Do I have to add anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I made some small changes. We can make more refinements later! Thanks!
Code Climate has analyzed commit 6549494 and detected 0 issues on this pull request. View more on Code Climate. |
Excellent, than kyou! |
…liclab#9744) * Expnaded the documentation about the stable and unstable servers * Added more information to docs * Apply suggestions from code review Co-authored-by: Jeffrey Warren <[email protected]>
…liclab#9744) * Expnaded the documentation about the stable and unstable servers * Added more information to docs * Apply suggestions from code review Co-authored-by: Jeffrey Warren <[email protected]>
…liclab#9744) * Expnaded the documentation about the stable and unstable servers * Added more information to docs * Apply suggestions from code review Co-authored-by: Jeffrey Warren <[email protected]>
Fixes #9718 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!