Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @rails/webpacker from 5.2.1 to 5.4.0 #9640

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 18, 2021

⚠️ Dependabot Preview has been deactivated ⚠️

This pull request was created by Dependabot Preview, and you've upgraded to Dependabot. This means it won't respond to dependabot commands nor will it be automatically closed if a new version is found.

If you close this pull request, Dependabot will re-create it the next time it checks for updates and everything will work as expected.


Bumps @rails/webpacker from 5.2.1 to 5.4.0.

Changelog

Sourced from @​rails/webpacker's changelog.

[5.4.0] - 2021-05-18

  • Fix compatibility with Psych 4

[5.3.0] - 2021-04-27

  • Adds experimental Yarn 2 support. Note you must manually set nodeLinker: node-modules in your .yarnrc.yml.

  • Keep backups, even when they're old #2912

[5.2.2] - 2021-04-27

  • Bump deps and remove node-sass #2997.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file JavaScript labels May 18, 2021
@gitpod-io
Copy link

gitpod-io bot commented May 18, 2021

@codeclimate
Copy link

codeclimate bot commented May 18, 2021

Code Climate has analyzed commit 5bf1776 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c4ecf7e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9640   +/-   ##
=======================================
  Coverage        ?   81.35%           
=======================================
  Files           ?       98           
  Lines           ?     5928           
  Branches        ?        0           
=======================================
  Hits            ?     4823           
  Misses          ?     1105           
  Partials        ?        0           

@jywarren
Copy link
Member

jywarren commented Jun 1, 2021

Hi @noi5e - no worries if you're busy, but if you had a suggestion as to how best to manually test webpack compilation, i wanted to do that in GitPod before merging this. Or is there a test that already does so? Thank you!!

@jywarren
Copy link
Member

jywarren commented Jun 1, 2021

Aha, never mind! Looks like rake assets:precompile does it, and it worked fine.

I did still see that warning:


WARNING in ./app/javascript/components/REACT_COMMENTS.md 1:0
Module parse failed: Unexpected character '#' (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> # `React Commenting System`
| 
| **Last Updated: 3/13/2021**
 @ ./app/javascript/components sync ^\.\/.*$ ./REACT_COMMENTS.md
 @ ./app/javascript/packs/server_rendering.js

but the site itself looked fine. Merging!

@jywarren jywarren merged commit 8d328a1 into main Jun 1, 2021
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/rails/webpacker-5.4.0 branch June 1, 2021 16:58
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Bumps [@rails/webpacker](https://github.com/rails/webpacker) from 5.2.1 to 5.4.0.
- [Release notes](https://github.com/rails/webpacker/releases)
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
- [Commits](rails/webpacker@v5.2.1...v5.4.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Bumps [@rails/webpacker](https://github.com/rails/webpacker) from 5.2.1 to 5.4.0.
- [Release notes](https://github.com/rails/webpacker/releases)
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
- [Commits](rails/webpacker@v5.2.1...v5.4.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant