Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specific ruby version #9463

Merged
merged 8 commits into from
Apr 6, 2021
Merged

specific ruby version #9463

merged 8 commits into from
Apr 6, 2021

Conversation

cesswairimu
Copy link
Collaborator

Fixes #9462 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2021

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@eb8522a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c6bfb2f differs from pull request most recent head 79409bb. Consider uploading reports for the commit 79409bb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9463   +/-   ##
=======================================
  Coverage        ?   77.50%           
=======================================
  Files           ?       98           
  Lines           ?     5930           
  Branches        ?        0           
=======================================
  Hits            ?     4596           
  Misses          ?     1334           
  Partials        ?        0           

@cesswairimu cesswairimu changed the title [attempt]specific ruby version specific ruby version Apr 6, 2021
@codeclimate
Copy link

codeclimate bot commented Apr 6, 2021

Code Climate has analyzed commit 79409bb and detected 0 issues on this pull request.

View more on Code Climate.

@cesswairimu cesswairimu mentioned this pull request Apr 6, 2021
5 tasks
@cesswairimu cesswairimu requested review from a team and removed request for a team April 6, 2021 10:49
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cesswairimu! Nice to see plots2 still thriving!

@cesswairimu
Copy link
Collaborator Author

Thanks @VladimirMikulic, great to see you :)

@cesswairimu cesswairimu merged commit 629e454 into main Apr 6, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* specific ruby version

* try again

* add ruby-version file

* remove ruby version

* remove ruby-version step

* replace 2.6 with 2.6.6

* remove ruby version file

Conflicts with rubocop

* add ruby version back
@jywarren jywarren mentioned this pull request Dec 14, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* specific ruby version

* try again

* add ruby-version file

* remove ruby version

* remove ruby-version step

* replace 2.6 with 2.6.6

* remove ruby version file

Conflicts with rubocop

* add ruby version back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing on all recent PRs
2 participants