Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon Font awesome error #8026

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8023
Added the font awesome cdn to map dependencies and modified one of the v5.0 icons to v4.7.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #8026 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8026      +/-   ##
==========================================
- Coverage   82.46%   82.34%   -0.13%     
==========================================
  Files          99       99              
  Lines        5737     5737              
==========================================
- Hits         4731     4724       -7     
- Misses       1006     1013       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.24% <0.00%> (-3.83%) ⬇️

@jywarren
Copy link
Member

Awesome!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix icons issue after migration to font-awesome-rails
2 participants