Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve acessibility of sidebar #7977

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

Tlazypanda
Copy link
Collaborator

@Tlazypanda Tlazypanda commented May 31, 2020

Fixes #7976
Improved accessibility of sidebar by adding aria-labels for missing form labels,empty buttons and empty links.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots

Before
7976_before_2

7974_after_1

After
7976_after
7976_after_2

Thanks!

@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #7977 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7977   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files          97       97           
  Lines        5642     5643    +1     
=======================================
+ Hits         4629     4630    +1     
  Misses       1013     1013           
Impacted Files Coverage Δ
app/controllers/stats_controller.rb 73.62% <100.00%> (+0.29%) ⬆️

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@jywarren jywarren merged commit 4b1ede8 into publiclab:master Jun 3, 2020
@jywarren
Copy link
Member

jywarren commented Jun 3, 2020

This is great. Super work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility of Sidebar
3 participants