Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated-redeploy Make task #6109

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

icarito
Copy link
Member

@icarito icarito commented Aug 5, 2019

This is a way to automated and trace our deployment process! It is currently working and triggered manually from Jenkins (must have pushed to stable branch first).

Note that currently it uses Makefile.beta which is a copy of the Makefile on disk. Makefile on disk has uncommitted changes that could conflict if this is merged (I've not tested what happens in the event of conflicts).

The idea is that Jenkins triggers a specific predefined command in production with the right environment (env vars and directory). This command is defined in this Makefile: make automated-redeploy which will:

  1. pull from stable branch
  2. initiate redeployment process

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@icarito icarito self-assigned this Jun 24, 2020
@jywarren jywarren changed the base branch from master to main June 30, 2020 18:00
@icarito icarito closed this Jul 1, 2020
@icarito icarito force-pushed the automated-redeploy branch from b7cc92b to 686197f Compare July 1, 2020 04:34
@icarito icarito reopened this Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #6109 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6109   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         100      100           
  Lines        5773     5773           
=======================================
  Hits         4737     4737           
  Misses       1036     1036           

@icarito
Copy link
Member Author

icarito commented Jul 1, 2020

This should be ready, it is rebased, prior tests failed for no discernible reason and then forgotten. Please merge.

@icarito icarito added the ready label Jul 1, 2020
@stale
Copy link

stale bot commented Oct 7, 2020

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.

@stale stale bot added the stale label Oct 7, 2020
@stale stale bot removed the stale label Oct 12, 2020
@jywarren jywarren merged commit 9fb6724 into publiclab:main Oct 12, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants