Unsubscribe from Node

[grvsachdeva]

Fixes #1610

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[plotsbot]

	2 Messages
📖	@gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[jywarren]

Hi, it looks like CodeClimate is asking for some improved security on redirects. You can see an example here:

plots2/app/controllers/notes_controller.rb

Line 36 in ed75ab7

redirect_to URI.parse(@node.path(:question)).path

The other is that it's seeming to want is_following? to become following?... interesting, and pretty easy to do, i think.

How does this sound? Thanks!!!

[grvsachdeva]

Actually , there is still some more work todo and after that I will resolve all code climate issues. Thanks!

[SidharthBansal]

@gauravano can we close this or will you be doing some work in this pr?

[grvsachdeva]

Hi @SidharthBansal I will be work on it soon. Thanks!

[grvsachdeva]

Hey everyone, closing this for now, as I don't think, I can complete this before summer. Sorry for the inconvenience.