Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page count #3156

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Profile page count #3156

merged 3 commits into from
Jul 27, 2018

Conversation

grvsachdeva
Copy link
Member

Fixes #3083

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost assigned grvsachdeva Jul 26, 2018
@ghost ghost added the in progress label Jul 26, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Jul 26, 2018

1 Warning
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
1 Message
📖 @Gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Hmm, looks like a conflict from the sidebar move -- but shouldn't be too big a deal!

@grvsachdeva
Copy link
Member Author

grvsachdeva commented Jul 26, 2018

Hi @jywarren please review this one

Updated pages count:

sec_count
first_count

Jeff your suggestions are required at #3137, #1610 and #3140 . Thanks!

@steviepubliclab
Copy link
Contributor

This is great! much more clear. Thanks!

@jywarren jywarren merged commit 900ac7d into publiclab:master Jul 27, 2018
@ghost ghost removed the ready label Jul 27, 2018
@jywarren
Copy link
Member

🎉 !!!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* profile count bug

* resolving conf and one more page optimized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counts on profiles incorrect.
4 participants