Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tested, fix missing POST route for openid decision - didn't work #2807

Closed
wants to merge 1 commit into from

Conversation

icarito
Copy link
Member

@icarito icarito commented Jun 9, 2018

This attempts to address #2727

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost assigned icarito Jun 9, 2018
@ghost ghost added the in progress label Jun 9, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Jun 9, 2018

2 Messages
📖 @icarito Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@icarito
Copy link
Member Author

icarito commented Jun 9, 2018

The thing is I don't know how to verify this works if deployed in e.g. unstable

@icarito
Copy link
Member Author

icarito commented Jun 9, 2018

Seems nobody uses openid anymore.

@icarito
Copy link
Member Author

icarito commented Jun 9, 2018

I spent a long while looking for a single working openid consuming website besides our own and I couldn't find one. Instead I'm going to try hotfixing this in production. Not sure why it would work for some and not others, maybe chaching.

@icarito
Copy link
Member Author

icarito commented Jun 9, 2018

Okay I briefly tried this in production and didn't work. I guess it was naive! But I did notice a comment in routes.rb - I'll make a note.

@icarito icarito changed the title Untested, fix missing POST route for openid decision. [WIP] Tested, fix missing POST route for openid decision - didn't work Jun 9, 2018
@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

Both sites can be run locally and pointed temporarily at each other

@jywarren
Copy link
Member

jywarren commented Jun 9, 2018

This all predates oauth ugh

@icarito icarito closed this Jun 10, 2018
@ghost ghost removed the in progress label Jun 10, 2018
@emilyashley emilyashley deleted the fix_openid_endpoint branch January 15, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants