Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

= :medium added to image.path #10100

Merged
merged 2 commits into from
Aug 25, 2021
Merged

= :medium added to image.path #10100

merged 2 commits into from
Aug 25, 2021

Conversation

jywarren
Copy link
Member

to fix #10099

@gitpod-io
Copy link

gitpod-io bot commented Aug 25, 2021

@daemon1024
Copy link
Member

Fixes #10083 as well

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #10100 (911db26) into main (f41f8e7) will decrease coverage by 0.14%.
The diff coverage is 85.29%.

❗ Current head 911db26 differs from pull request most recent head 3e4c5a4. Consider uploading reports for the commit 3e4c5a4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10100      +/-   ##
==========================================
- Coverage   82.13%   81.98%   -0.15%     
==========================================
  Files          98       98              
  Lines        5968     5974       +6     
==========================================
- Hits         4902     4898       -4     
- Misses       1066     1076      +10     
Impacted Files Coverage Δ
app/models/tag.rb 93.26% <44.44%> (-4.27%) ⬇️
app/controllers/home_controller.rb 96.05% <100.00%> (-2.62%) ⬇️
app/controllers/images_controller.rb 70.27% <100.00%> (ø)
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/controllers/tag_controller.rb 80.42% <100.00%> (ø)
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/models/image.rb 82.05% <100.00%> (-0.45%) ⬇️
app/models/user.rb 86.12% <100.00%> (ø)
app/services/search_service.rb 94.89% <100.00%> (-0.21%) ⬇️
... and 3 more

@codeclimate
Copy link

codeclimate bot commented Aug 25, 2021

Code Climate has analyzed commit 3e4c5a4 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren jywarren merged commit 733605b into main Aug 25, 2021
@jywarren
Copy link
Member Author

Added a unit test, i hope this will work!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* = :medium added to image.path

to fix publiclab#10099

* Update image_test.rb
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* = :medium added to image.path

to fix publiclab#10099

* Update image_test.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in tag pages
2 participants