-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed "Ask a Question" String to Translation Function Call" #10075 #10077
Conversation
+902 question: "Ask a Question of the Public Lab Community"
-36 <h2>Ask a question of the PublicLab community</h2> +36 <h2><%=translation('editor.post.question')%></h2>
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 63627c7 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #10077 +/- ##
==========================================
- Coverage 82.13% 81.98% -0.15%
==========================================
Files 98 98
Lines 5968 5974 +6
==========================================
- Hits 4902 4898 -4
- Misses 1066 1076 +10
|
Hey @noi5e, I have generated the PR. Can you please review it? A small step by me towards a better OpenSource :) |
System tests look a little buggy, going to close and reopen this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RazaKhanGit Great job! 🎉 Welcome to Public Lab 🎈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @RazaKhanGit!
I don't have merge access for this one, I think because editor-maintainers are a reviewer. Tagging this as merge-ready for @jywarren. |
Thank you so much. Excellent work. Merging!!! 🎉 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
…ab#10075 (publiclab#10077) * Update en.yml(publiclab#10075) +902 question: "Ask a Question of the Public Lab Community" * Update questionRich.html.erb(publiclab#10075 -36 <h2>Ask a question of the PublicLab community</h2> +36 <h2><%=translation('editor.post.question')%></h2>
…ab#10075 (publiclab#10077) * Update en.yml(publiclab#10075) +902 question: "Ask a Question of the Public Lab Community" * Update questionRich.html.erb(publiclab#10075 -36 <h2>Ask a question of the PublicLab community</h2> +36 <h2><%=translation('editor.post.question')%></h2>
Updated config/locales/en.yml:
+902 question: "Ask a Question of the Public Lab Community"
Updated app/views/editor/questionRich.html.erb:
-36 <h2>Ask a question of the PublicLab community</h2>
+36 <h2><%=translation('editor.post.question')%></h2>
Fixes #10075
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below