Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "Ask a Question" String to Translation Function Call" #10075 #10077

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

RazaKhanGit
Copy link
Contributor

@RazaKhanGit RazaKhanGit commented Aug 22, 2021

Updated config/locales/en.yml:
+902 question: "Ask a Question of the Public Lab Community"

Updated app/views/editor/questionRich.html.erb:
-36 <h2>Ask a question of the PublicLab community</h2>
+36 <h2><%=translation('editor.post.question')%></h2>

Fixes #10075

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

+902 question: "Ask a Question of the Public Lab Community"
-36 <h2>Ask a question of the PublicLab community</h2>
+36 <h2><%=translation('editor.post.question')%></h2>
@welcome
Copy link

welcome bot commented Aug 22, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Aug 22, 2021

@codeclimate
Copy link

codeclimate bot commented Aug 22, 2021

Code Climate has analyzed commit 63627c7 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #10077 (0889a54) into main (f41f8e7) will decrease coverage by 0.14%.
The diff coverage is 83.33%.

❗ Current head 0889a54 differs from pull request most recent head 63627c7. Consider uploading reports for the commit 63627c7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10077      +/-   ##
==========================================
- Coverage   82.13%   81.98%   -0.15%     
==========================================
  Files          98       98              
  Lines        5968     5974       +6     
==========================================
- Hits         4902     4898       -4     
- Misses       1066     1076      +10     
Impacted Files Coverage Δ
app/models/tag.rb 93.26% <44.44%> (-4.27%) ⬇️
app/controllers/home_controller.rb 96.00% <100.00%> (-2.67%) ⬇️
app/controllers/images_controller.rb 70.27% <100.00%> (ø)
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/controllers/tag_controller.rb 80.42% <100.00%> (ø)
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/services/search_service.rb 94.89% <100.00%> (-0.21%) ⬇️
app/models/node.rb 90.71% <0.00%> (-0.34%) ⬇️
... and 1 more

@RazaKhanGit
Copy link
Contributor Author

Hey @noi5e, I have generated the PR. Can you please review it? A small step by me towards a better OpenSource :)

@RazaKhanGit RazaKhanGit reopened this Aug 22, 2021
@RazaKhanGit RazaKhanGit marked this pull request as ready for review August 22, 2021 18:15
@RazaKhanGit RazaKhanGit requested a review from a team as a code owner August 22, 2021 18:15
@noi5e
Copy link
Contributor

noi5e commented Aug 23, 2021

System tests look a little buggy, going to close and reopen this PR.

@noi5e noi5e closed this Aug 23, 2021
@noi5e noi5e reopened this Aug 23, 2021
Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RazaKhanGit Great job! 🎉 Welcome to Public Lab 🎈

Copy link
Contributor

@noi5e noi5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @RazaKhanGit!

@noi5e noi5e requested a review from jywarren August 24, 2021 18:32
@noi5e
Copy link
Contributor

noi5e commented Aug 24, 2021

I don't have merge access for this one, I think because editor-maintainers are a reviewer. Tagging this as merge-ready for @jywarren.

@noi5e noi5e mentioned this pull request Aug 27, 2021
5 tasks
@jywarren
Copy link
Member

Thank you so much. Excellent work. Merging!!!

🎉

@jywarren jywarren merged commit 27a575f into publiclab:main Aug 31, 2021
@welcome
Copy link

welcome bot commented Aug 31, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
…ab#10075 (publiclab#10077)

* Update en.yml(publiclab#10075)

+902 question: "Ask a Question of the Public Lab Community"

* Update questionRich.html.erb(publiclab#10075

-36 <h2>Ask a question of the PublicLab community</h2>
+36 <h2><%=translation('editor.post.question')%></h2>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…ab#10075 (publiclab#10077)

* Update en.yml(publiclab#10075)

+902 question: "Ask a Question of the Public Lab Community"

* Update questionRich.html.erb(publiclab#10075

-36 <h2>Ask a question of the PublicLab community</h2>
+36 <h2><%=translation('editor.post.question')%></h2>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Ask a Question" String to Translation Function Call
4 participants