write tests that assert the markers are shown or hidden as in the new example code #52

sagarpreet-chadha · 2019-03-08T11:12:33Z

Fixes #45 !

sagarpreet-chadha · 2019-03-08T11:36:31Z

dist/Leaflet.BlurredLocationDisplay.js is not being loaded before the tests are loaded . Can you help in setting up the testing environment ? Thanks !

sagarpreet-chadha · 2019-03-08T18:56:36Z

Hi @jywarren ,
Kindly take a look at it once 😄 !

jywarren · 2019-03-13T14:20:44Z

Gruntfile.js

+             'node_modules/jasmine-ajax/lib/mock-ajax.js',
+             'https://maps.googleapis.com/maps/api/js?libraries=places&language=en&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE',
+             'node_modules/leaflet/dist/leaflet-src.js',
+             'node_modules/leaflet-blurred-location/dist/Leaflet.BlurredLocation.js' ,


Here i think you need to include the LBLD library itself! See for reference:

https://github.com/publiclab/leaflet-blurred-location/blob/4f452d5cc486ac320fa168eeabbb46bedb1b8378/Gruntfile.js#L31-L41

jywarren · 2019-03-13T14:21:08Z

spec/javascripts/fixtures/example.html

+    <link href="../../../node_modules/leaflet/dist/leaflet.css" rel="stylesheet">
+    <script src="../../../node_modules/leaflet/dist/leaflet.js"></script>
+    <script src="../../../node_modules/leaflet-blurred-location/dist/Leaflet.BlurredLocation.js"></script>
+    <script src="../../../dist/Leaflet.BlurredLocationDisplay.js"></script>


So i think you may want to load these in the Gruntfile on these lines: https://github.com/publiclab/leaflet-blurred-location-display/pull/52/files#diff-35b4a816e0441e6a375cd925af50752cR35

because they won't be loaded from this file until you load the fixture. And some of the tests you may not actually want the HTML fixture data, but just to test basic methods in the JS lib.

See for example:

https://github.com/publiclab/leaflet-blurred-location/blob/4f452d5cc486ac320fa168eeabbb46bedb1b8378/spec/javascripts/fixtures/index.html#L5-L8

sagarpreet-chadha · 2019-03-14T17:44:58Z

Yes tried that as well !
Added LBL , LBLD dependencies in vendor , still showing the same error .
LBLD is not getting loaded before the specs starts running .

jywarren · 2019-03-15T18:38:56Z

Hmm, confusing. Maybe you have to include the source files like this?

https://github.com/publiclab/PublicLab.Editor/blob/master/Gruntfile.js#L44-L46

If this doesn't work, maybe ping @rexagod or someone else from image-sequencer as they are really good with test setup!

sagarpreet-chadha · 2019-03-21T17:29:09Z

Hey @rexagod , @tech4GT , @publiclab/reviewers !
Can someone with good testing background help me solve this one ? Looking forward to hear from you guys 😄 . Thank you :)

rexagod · 2019-03-21T22:31:25Z

Noticing that Travis and local both give different errors (BlurredLocation and BlurredLocationDisplay respectively). @sagarpreet-chadha Are you getting an asynchronous warning in your logs as well?

Working on this.

rexagod · 2019-03-23T11:48:22Z

spec/javascripts/test_spec.js

+
+  it("Checks if at zoom level 5 , all 7 markers are shown", function () {
+    //BlurredLocation1.map.setZoom(5);
+    expect($("#map1").children()[0].childNodes[3].childNodes.length).toBe(0) ;


expect($("#map1").children()[0].childNodes[3].childNodes.length).toBe(7) ;

Hi @rexagod , yes i did that purposely to tell you guys that in testing , markers are not getting loaded on map 😄 !

rexagod · 2019-03-23T11:48:40Z

spec/javascripts/test_spec.js

+
+  it("Checks if at zoom level 6 , only 5 markers are shown", function () {
+    //BlurredLocation2.map.setZoom(6);
+    expect($("#map2").children()[0].childNodes[3].childNodes.length).toBe(0) ;


expect($("#map1").children()[0].childNodes[3].childNodes.length).toBe(5) ;

rexagod · 2019-03-23T11:48:57Z

spec/javascripts/test_spec.js

+
+  it("Checks if at zoom level 8 , only 3 markers are shown", function () {
+   // BlurredLocation3.map.setZoom(8);
+    expect($("#map3").children()[0].childNodes[3].childNodes.length).toBe(0) ;


expect($("#map1").children()[0].childNodes[3].childNodes.length).toBe(3) ;

rexagod · 2019-03-23T11:52:44Z

Hello, @sagarpreet-chadha! I've made some comments above, depending on some checks I made below.

PS. All the tests are passing if length is expected to be 0, meaning that for some reason the DOMchildren aren't being loaded.

rexagod · 2019-03-23T12:16:02Z

Getting contradicting results.

rexagod · 2019-03-23T12:22:12Z

Made some changes along the way.

leaflet-blurred-location-display/src/ui/gridCenterRectangle.js

Line 43 in 246b4da

if(map.getZoom() >= 3 && map.getZoom() <=9){

Changed to if(map && map.getZoom() >= 3 && map.getZoom() <=9), since getZoom wasn't initialized onDOMload so we might want to look into that as well.

leaflet-blurred-location-display/src/ui/gridCenterRectangle.js

Line 35 in 246b4da

if(typeof options.blurredLocation.getRectangle() !== "undefined"){

if(typeof options.blurredLocation.getRectangle !== "undefined"), removed parenthesis from above, since getRectangle itself wasn't on blurredLocation's chain.

sagarpreet-chadha · 2019-03-28T05:43:10Z

Hi @rexagod ...thank you for the recommendations 😄 . What do you think could be the possible reason that LBL and LBLD libraries are not getting loaded before testing starts ? Thanks !

sagarpreet-chadha · 2019-03-28T17:25:26Z

Thank you @arpansac , the fixtures are now being loaded 🎉 .
2 out of 5 tests are running now 👍 .

Also now all libraries are also getting loaded except LBLD .

Now we just have to figure why LBLD is not getting loaded . Thanks all 😄 !

sagarpreet-chadha · 2019-04-01T10:20:30Z

We use Jasmine jquery to load fixtures , but this package is not maintained . Also see this which i found in its documentation (this should solve the error which one gets when grunt jasmine is run on localhost) :
Source : https://github.com/velesin/jasmine-jquery

And this error on Travis 😄 asks to open issue in puppeteer package :

sagarpreet-chadha · 2019-04-01T12:42:56Z

grunt-contrib-Jasmine runs on phantomJS , and phantomJS does not support ES6 !

sagarpreet-chadha · 2019-04-01T12:56:22Z

YAYYY 🎉

I think i will write a blog about it :P .
So some ES6 functions were causing problem because phantomJS does not support ES6 !
And regarding LBLD not loading in fixtures --- it is yet an unsolved issue in Jasmine-jquery !

@jywarren ...kindly review 😄 !
Should we add put this library to npm ?

sagarpreet-chadha · 2019-04-02T07:05:10Z

@jywarren ...kindly review this one as well 😄 !

jywarren · 2019-04-02T16:16:44Z

OK! Sorry i had replied via email but it didn't go through!

jywarren · 2019-04-02T16:18:25Z

Awesome! Thanks Sagarpreet and great problem solving, this was such a tough one. I'm sorry i wasn't able to help more! Perhaps a good deal of this testing workflow is starting to age a bit. But you got it! 🙌

sagarpreet-chadha added 5 commits March 8, 2019 13:51

heatmap color remains same

d3b043a

over ride method for zoomlevel , precision created

226e3bd

Update README.md

112185d

testing init

7b2b458

jasmine.json changed

199ca0d

tests added

174de81

jywarren reviewed Mar 13, 2019

View reviewed changes

jywarren mentioned this pull request Mar 13, 2019

Planning overview (revised!) publiclab/leaflet-environmental-layers#134

Open

46 tasks

sagarpreet-chadha added 3 commits March 14, 2019 17:12

done changes

21152a7

conflicts resolved

6a753c4

changes recommended by jeff

1be8a18

test

dae107f

rexagod reviewed Mar 23, 2019

View reviewed changes

sagarpreet-chadha added 2 commits March 28, 2019 11:44

gruntfile modified

05b4496

last test runs now/fixtures are loaded now

a605c73

sagarpreet-chadha closed this Mar 28, 2019

sagarpreet-chadha reopened this Mar 28, 2019

sagarpreet-chadha added 2 commits April 1, 2019 13:08

Merge branch 'main' into feature_testing

8a24f89

specRunner added

afe7aec

sagarpreet-chadha mentioned this pull request Apr 1, 2019

Weekly Community Check-in # 16 publiclab/PublicLab.Editor#317

Closed

tests running now :)

095a060

sagarpreet-chadha requested a review from jywarren April 1, 2019 12:56

sagarpreet-chadha added the review-me label Apr 1, 2019

jywarren approved these changes Apr 2, 2019

View reviewed changes

jywarren merged commit ab0774f into main Apr 2, 2019

jywarren mentioned this pull request Jul 8, 2019

[WIP] Test indigeneous layers publiclab/leaflet-environmental-layers#222

Merged

5 tasks

sagarpreet-chadha mentioned this pull request Oct 14, 2020

Setup babel publiclab/PublicLab.Editor#614

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

write tests that assert the markers are shown or hidden as in the new example code #52

write tests that assert the markers are shown or hidden as in the new example code #52

sagarpreet-chadha commented Mar 8, 2019

sagarpreet-chadha commented Mar 8, 2019

sagarpreet-chadha commented Mar 8, 2019

jywarren Mar 13, 2019

jywarren Mar 13, 2019

sagarpreet-chadha commented Mar 14, 2019

jywarren commented Mar 15, 2019

sagarpreet-chadha commented Mar 21, 2019

rexagod commented Mar 21, 2019

rexagod Mar 23, 2019

sagarpreet-chadha Mar 28, 2019

rexagod Mar 23, 2019

rexagod Mar 23, 2019

rexagod commented Mar 23, 2019 •

edited

Loading

rexagod commented Mar 23, 2019 •

edited

Loading

rexagod commented Mar 23, 2019 •

edited

Loading

sagarpreet-chadha commented Mar 28, 2019

sagarpreet-chadha commented Mar 28, 2019

sagarpreet-chadha commented Apr 1, 2019

sagarpreet-chadha commented Apr 1, 2019

sagarpreet-chadha commented Apr 1, 2019

sagarpreet-chadha commented Apr 2, 2019

jywarren commented Apr 2, 2019

jywarren commented Apr 2, 2019

write tests that assert the markers are shown or hidden as in the new example code #52

write tests that assert the markers are shown or hidden as in the new example code #52

Conversation

sagarpreet-chadha commented Mar 8, 2019

sagarpreet-chadha commented Mar 8, 2019

sagarpreet-chadha commented Mar 8, 2019

jywarren Mar 13, 2019

Choose a reason for hiding this comment

jywarren Mar 13, 2019

Choose a reason for hiding this comment

sagarpreet-chadha commented Mar 14, 2019

jywarren commented Mar 15, 2019

sagarpreet-chadha commented Mar 21, 2019

rexagod commented Mar 21, 2019

rexagod Mar 23, 2019

Choose a reason for hiding this comment

sagarpreet-chadha Mar 28, 2019

Choose a reason for hiding this comment

rexagod Mar 23, 2019

Choose a reason for hiding this comment

rexagod Mar 23, 2019

Choose a reason for hiding this comment

rexagod commented Mar 23, 2019 • edited Loading

rexagod commented Mar 23, 2019 • edited Loading

rexagod commented Mar 23, 2019 • edited Loading

sagarpreet-chadha commented Mar 28, 2019

sagarpreet-chadha commented Mar 28, 2019

sagarpreet-chadha commented Apr 1, 2019

sagarpreet-chadha commented Apr 1, 2019

sagarpreet-chadha commented Apr 1, 2019

sagarpreet-chadha commented Apr 2, 2019

jywarren commented Apr 2, 2019

jywarren commented Apr 2, 2019

rexagod commented Mar 23, 2019 •

edited

Loading

rexagod commented Mar 23, 2019 •

edited

Loading

rexagod commented Mar 23, 2019 •

edited

Loading