Sending draft status in output from PL Editor #2677 #138
Conversation
dist/PublicLab.Editor.js
Outdated
|
|
||
| output.authenticity_token = data.token || null; | ||
| // Whether note will be draft or not | ||
| output.draft = data.draft || false; |
There was a problem hiding this comment.
Awesome !!! how about introducing new lines aroud these 2 lines as it's looking bit of messy. Thanks @poppashingles .
There was a problem hiding this comment.
New lines added, thanks!
package-lock.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
Can't say about this. Let's ask @jywarren about it.
There was a problem hiding this comment.
Its still there, could you please try one more time to remove it
There was a problem hiding this comment.
Hiya. In my forked one the package lock is gone and the pull request seems to be saying everything in it is gone. Am I reading it wrong?
|
Yes, But looking great, thank you both! |
…d removed the package-lock file
|
Thanks @jywarren :) I've removed the package-lock and moved the code into the PublicLab.Formatter.js file in src/adapters. Thanks again! |
| output.authenticity_token = data.token || null; | ||
|
|
||
| // Whether note will be draft or not | ||
| output.draft = data.draft || false; |
|
@poppashingles how about opening a new PR just by adding lines in the concerned file from Github so that we don't get any extra additions and deletions? What do you think? |
|
hi @poppashingles , I have resolved the conflict with the |
|
hey @jywarren its ready now. Please review it. thanks. |
|
Thanks guys. Sorry it's not gone particularly smoothly! Been a really good learning experience though so thank you :) |
|
No issue @poppashingles, we all are here for learning and I will also try to open more clear FTO from next time, this time I messed up a little. Thanks for the help! Also, if you like to solve more issues, you can find them here https://publiclab.github.io/community-toolbox/#r=all |
|
Hi, all - thanks so much @poppashingles and @Gauravano for taking this one on! I think it just needs one more run of Again, great work and thank you! |
|
hi @jywarren , I have run the |
|
Awesome, merging now then! |
|
For this to show up on publiclab.org we now need to bump the version number by a |
|
Ok, did that! Now we need to grab the latest version on publiclab.org with
`bower update` - you should be able to do this locally to test!
…On Wed, May 16, 2018, 12:11 PM Gaurav Sachdeva ***@***.***> wrote:
hi @jywarren <https://github.com/jywarren> , I have run the grunt build.
please review it again. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_8I5KOUVfMaHxlLA5wfMuOEdLeTks5tzHnVgaJpZM4Tt8OA>
.
|
|
Hey, @jywarren thanks for merging this. I have checked locally, changes are in place. |
I had to delete the package-lock file and rebuild it, so it's updated a lot of the dependencies. All 25 tests are still passing ok on my local version.