Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentence scoring logic considering cases #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

min9079
Copy link

@min9079 min9079 commented Apr 15, 2014

when there are multiple clusters in a sentence
with higher score value on the prior one.

Additionally, I also modified entity choosing logic to include last NN word in the sentence.

min9079 added 2 commits April 15, 2014 18:32
 when there are multiple clusters in a sentence
 with higher score value on the prior one.
@min9079
Copy link
Author

min9079 commented May 13, 2014

Any comment on the change set?

@@ -569,22 +569,26 @@
" pos_tagged_tokens = [token for sent in pos_tagged_tokens for token in sent]\n",
"\n",
" all_entity_chunks = []\n",
" previous_pos = None\n",
" current_status = 'None-NN'\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for taking so long to merge in this change. I'm just not totally sure where you're going with this second part of the diff where you are materializing current_status. Can you explain what's going on here?

@ptwobrussell
Copy link
Owner

Yes, just left you a request for comment so I can more carefully review part of the diff. Sorry it's taking me so long to get this merged in, but I hope to merge it as soon as I hear back from you and read the code through one more time.

On May 13, 2014, at 3:15 AM, Ku Bong Min [email protected] wrote:

Any comment on the change set?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants