Skip to content

Commit

Permalink
Make common RTCOfferAnswerOptions class.
Browse files Browse the repository at this point in the history
  • Loading branch information
@pthatcherg
pthatcherg committed Dec 30, 2014
1 parent d3e4b54 commit 90af82e
Showing 1 changed file with 16 additions and 19 deletions.
35 changes: 16 additions & 19 deletions webrtc.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,21 @@ <h4>Offer/Answer Options</h4>
<p>These dictionaries describe the options that can be used to control
the offer/answer creation process.</p>

<dl class="idl" title="dictionary RTCOfferOptions">
<dl class="idl" title="dictionary RTCOfferAnswerOptions">
<dt>boolean voiceActivityDetection = true</dt>

This comment has been minimized.

Sign in to view

Copy link
@jan-ivar

jan-ivar Mar 10, 2015

Note that by providing a default value of true, we remove the ability of the UA to distinguish users who desire voiceActivityDetection from users who don't care. In other words: this removes any UA-specific default of AUTO, and effectively mandates that if a UA is capable of such features, then it MUST enable them by default whether the user has requested them or not (i.e. unless the user explicitly turns it off). This may be fine, I just wanted to put it out there. Are such features cost-free even on mobile devices?

Whoops, just realized this wasn't actually a net change of this PR. Nm.

<dd>
<p>Many codecs and system are capable of detecting "silence" and
changing their behavior in this case by doing things such as not
transmitting any media. In many cases, such as when dealing with
emergency calling or sounds other than spoken voice, it is
desirable to be able to turn off this behavior. This option allows
the application to provide information about whether it wishes this
type of processing enabled or disabled.</p>
</dd>
</dl>

<dl class="idl" title="dictionary RTCOfferOptions : RTCOfferAnswerOptions">
<dt>long offerToReceiveVideo</dt>

<dd>
Expand All @@ -254,18 +268,6 @@ <h4>Offer/Answer Options</h4>
audio streams to receive when creating an offer.</p>
</dd>

<dt>boolean voiceActivityDetection = true</dt>

<dd>
<p>Many codecs and system are capable of detecting "silence" and
changing their behavior in this case by doing things such as not
transmitting any media. In many cases, such as when dealing with
emergency calling or sounds other than spoken voice, it is
desirable to be able to turn off this behavior. This option allows
the application to provide information about whether it wishes this
type of processing enabled or disabled.</p>
</dd>

<dt>boolean iceRestart = false</dt>

<dd>
Expand All @@ -283,12 +285,7 @@ <h4>Offer/Answer Options</h4>
</dd>
</dl>

<dl class="idl" title="dictionary RTCAnswerOptions">
<dt>boolean voiceActivityDetection = true</dt>

<dd>
<p>See <a href="#widl-RTCOfferOptions-voiceActivityDetection">RTCOfferOptions.voiceActivityDetection.</a></p>
</dd>
<dl class="idl" title="dictionary RTCAnswerOptions : RTCOfferAnswerOptions">
</dl>

<dl class="idl" title="enum RTCIdentityOption">
Expand Down

0 comments on commit 90af82e

Please sign in to comment.