Do not use std::io::IoSlice in libxcb's FFI
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, xcb defines its own `iovec` struct in `xcb_windefs.h`, which does not match the `WSABUF` struct used in `IoSlice`.
psychon
reviewed
Mar 10, 2020
| use libc::{c_char, c_int, c_uint}; | ||
|
|
||
| // As defined in xcb_windefs.h | ||
| #[cfg(not(unix))] | ||
| #[derive(Copy, Clone, Debug)] |
There was a problem hiding this comment.
Why Copy and Clone? std::io::IoSlice only has Debug and Deref.
There was a problem hiding this comment.
But iovec from libc has Copy and Clone (but not Debug).
There is a PR to implemente Copy and Clone for std::io::IoSlice.
Anyways we are not using them and the definition is private, so we could remove them.
|
How did you find this? Did this actually break something, or did you just come across this "accidentally"? |
Just accidentally, I didn't have the chance to test x11rb on Windows yet. |
psychon
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, xcb defines its own
iovecstruct inxcb_windefs.h, which does not match theWSABUFstruct used inIoSlice.