Merge pull request #5414 from mondeja/5367

Raise InvalidUrl if host starts with '.' character.
psf · Dec 29, 2021 · d096599 · d096599
2 parents 2b06a95 + 658c10e
commit d096599
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/requests/models.py b/requests/models.py
@@ -403,7 +403,7 @@ def prepare_url(self, url, params):
                 host = self._get_idna_encoded_host(host)
             except UnicodeError:
                 raise InvalidURL('URL has an invalid label.')
-        elif host.startswith(u'*'):
+        elif host.startswith((u'*', u'.')):
             raise InvalidURL('URL has an invalid label.')
 
         # Carefully reconstruct the network location

diff --git a/tests/test_requests.py b/tests/test_requests.py
@@ -81,6 +81,8 @@ def test_entry_points(self):
             (InvalidSchema, 'localhost.localdomain:3128/'),
             (InvalidSchema, '10.122.1.1:3128/'),
             (InvalidURL, 'http://'),
+            (InvalidURL, 'http://*example.com'),
+            (InvalidURL, 'http://.example.com'),
         ))
     def test_invalid_url(self, exception, url):
         with pytest.raises(exception):