Skip to content

Commit

Permalink
Update pylint config docs (#2931)
Browse files Browse the repository at this point in the history
  • Loading branch information
jpy-git authored Mar 16, 2022
1 parent 086ae68 commit fa7f015
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 37 deletions.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
<!-- Major changes to documentation and policies. Small docs changes
don't need a changelog entry. -->

- Update pylint config documentation (#2931)

### Integrations

<!-- For example, Docker, GitHub Actions, pre-commit, editors -->
Expand Down
3 changes: 0 additions & 3 deletions docs/compatible_configs/pylint/pylintrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
[MESSAGES CONTROL]
disable = C0330, C0326

[format]
max-line-length = 88
3 changes: 0 additions & 3 deletions docs/compatible_configs/pylint/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
[tool.pylint.messages_control]
disable = "C0330, C0326"

[tool.pylint.format]
max-line-length = "88"
3 changes: 0 additions & 3 deletions docs/compatible_configs/pylint/setup.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
[pylint]
max-line-length = 88

[pylint.messages_control]
disable = C0330, C0326
32 changes: 4 additions & 28 deletions docs/guides/using_black_with_other_tools.md
Original file line number Diff line number Diff line change
Expand Up @@ -210,41 +210,23 @@ mixed feelings about _Black_'s formatting style.
#### Configuration

```
disable = C0326, C0330
max-line-length = 88
```

#### Why those options above?

When _Black_ is folding very long expressions, the closing brackets will
[be dedented](../the_black_code_style/current_style.md#how-black-wraps-lines).
Pylint should be configured to only complain about lines that surpass `88` characters
via `max-line-length = 88`.

```py3
ImportantClass.important_method(
exc, limit, lookup_lines, capture_locals, callback
)
```

Although this style is PEP 8 compliant, Pylint will raise
`C0330: Wrong hanging indentation before block (add 4 spaces)` warnings. Since _Black_
isn't configurable on this style, Pylint should be told to ignore these warnings via
`disable = C0330`.

Also, since _Black_ deals with whitespace around operators and brackets, Pylint's
warning `C0326: Bad whitespace` should be disabled using `disable = C0326`.

And as usual, Pylint should be configured to only complain about lines that surpass `88`
characters via `max-line-length = 88`.
If using `pylint<2.6.0`, also disable `C0326` and `C0330` as these are incompatible with
_Black_ formatting and have since been removed.

#### Formats

<details>
<summary>pylintrc</summary>

```ini
[MESSAGES CONTROL]
disable = C0326, C0330

[format]
max-line-length = 88
```
Expand All @@ -257,9 +239,6 @@ max-line-length = 88
```cfg
[pylint]
max-line-length = 88
[pylint.messages_control]
disable = C0326, C0330
```

</details>
Expand All @@ -268,9 +247,6 @@ disable = C0326, C0330
<summary>pyproject.toml</summary>

```toml
[tool.pylint.messages_control]
disable = "C0326, C0330"

[tool.pylint.format]
max-line-length = "88"
```
Expand Down

0 comments on commit fa7f015

Please sign in to comment.