Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatible error #154

Closed
wants to merge 1 commit into from
Closed

Fix compatible error #154

wants to merge 1 commit into from

Conversation

tm1000
Copy link
Contributor

@tm1000 tm1000 commented Jun 21, 2021

Fixes: Declaration of Psalm\LaravelPlugin\FakeMetaCommand::registerClassAutoloadExceptions() must be compatible with Barryvdh\LaravelIdeHelper\Console\MetaCommand::registerClassAutoloadExceptions(): callable

In barryvdh/laravel-ide-helper@ca94ffd callable was added to registerClassAutoloadExceptions

Fixes: `Declaration of Psalm\LaravelPlugin\FakeMetaCommand::registerClassAutoloadExceptions() must be compatible with Barryvdh\LaravelIdeHelper\Console\MetaCommand::registerClassAutoloadExceptions(): callable`

In barryvdh/laravel-ide-helper@ca94ffd callable was added to `registerClassAutoloadExceptions`
@mr-feek
Copy link
Collaborator

mr-feek commented Jun 21, 2021

This plugin is currently not compatible with "barryvdh/laravel-ide-helper": ">=2.9.2" due to barryvdh/laravel-ide-helper#945 (comment) unfortunately.

I don't want to allow >=2.9.2 at the moment as laravel-ide-helper dropped support for laravel 6 and 7

@tm1000
Copy link
Contributor Author

tm1000 commented Jun 22, 2021

@mr-feek makes sense but it seems your version constraints dont work as I was able to install this without any issues.

Why not go to another major version?

Nevermind read your comments in the linked thread :-)

@mr-feek
Copy link
Collaborator

mr-feek commented Jun 29, 2021

gonna close this for now as I think through a proper solution some more. I'm trying to remove ide-helper altogether at the moment. Thanks for the PR though!

@mr-feek mr-feek closed this Jun 29, 2021
@tm1000
Copy link
Contributor Author

tm1000 commented Jun 29, 2021

@mr-feek all good. Will look forward to whatever you do!

also I hear you on not requiring that. I’m running into the same issue with some language sever bugs in Psalm itself that seem to come from a package that hasn’t been updated in 2018. Sometimes it’s just better to maintain it yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants