Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent installation of barryvdh/laravel-ide-helper 2.9.2 and later #138

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Prevent installation of barryvdh/laravel-ide-helper 2.9.2 and later #138

merged 1 commit into from
Apr 7, 2021

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 6, 2021

This avoids a BC break in barryvdh/laravel-ide-helper 2.9.2, which changed the visibility of several methods from protected to public.

This avoids a BC break in `barryvdh/laravel-ide-helper` 2.9.2, which changed the visibility of several methods from `protected` to `public`.
@caugner
Copy link
Contributor Author

caugner commented Apr 6, 2021

@mr-feek I suggest to release this change as 1.4.3 asap to avoid trouble for users that update their Composer dependencies these days.

Then, #136 could be merged as soon as the laravel-ide-helper interface has stabilised, see my comment in #136.

PS: If master is not ready, you could branch from the 1.4.2 release to release just this mitigation.

@mr-feek
Copy link
Collaborator

mr-feek commented Apr 7, 2021

Thanks!

@mr-feek mr-feek merged commit d00e50e into psalm:master Apr 7, 2021
@mr-feek
Copy link
Collaborator

mr-feek commented Apr 7, 2021

cut a new release

@caugner caugner deleted the patch-1 branch April 7, 2021 19:07
@securit
Copy link

securit commented Aug 1, 2021

Default deployment of barryvdh/laravel_ide_helper is now v2.10.0. Is this sufficiently stable now to update the version restrictions?

@mr-feek
Copy link
Collaborator

mr-feek commented Aug 2, 2021

ide-helper dropped support for the LTS version of laravel, which I don't want to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants