Display error in "Finished building block" only if error. #14722
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: OK it's not different at all. I misread it. Sure, this is OK. Thanks |
prestonvanloon
approved these changes
Dec 13, 2024
rkapka
reviewed
Dec 13, 2024
| if err != nil { | ||
| log.WithError(err).Error("Finished building block") |
There was a problem hiding this comment.
Should the error path still say Finished building block? I think something like Could not build block/Failed to build block would be more appropriate
There was a problem hiding this comment.
I take it back. The log level makes it clear there was an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
When building a block, display the error only if not
nil.Before:
After:
Acknowledgements