Fix Event stream with carriage return support #14250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the submission, looks like there is a lint issue api/client/event/utils.go:36: File is not |
samuel-videau
force-pushed
the
fix/scanner_carriage
branch
from
0630e3c to
8763a01
Compare
|
My bad, should be good now! |
|
looks like there are some linter rule issues ( bazel file) |
Ah that's a shame sorry for that, should be good now |
james-prysm
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Add supports to
\ras a separator while processing event streams, and therefore adhering to https://html.spec.whatwg.org/multipage/server-sent-events.html#the-eventsource-interfaceWhich issues(s) does this PR fix?
Fixes #13730
Other notes for review
The utility function added is just a slight modification of the ScanLines function in scan.go