Do not fail production when consensus block value is unavailable #14111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
rkapka
force-pushed
the
sync-rewards-fail
branch
from
ffb3eb1 to
df4490b
Compare
james-prysm
reviewed
Jun 14, 2024
| @@ -297,8 +297,8 @@ func getConsensusBlockValue(ctx context.Context, blockRewardsFetcher rewards.Blo | |||
| } | |||
| } | |||
| if bb.Version() == version.Phase0 { | |||
| // ignore for phase 0 | |||
| return "", nil | |||
| // Getting the block value for Phase 0 is very hard, so we ignore it | |||
There was a problem hiding this comment.
should we at least add a debug log or something
james-prysm
reviewed
Jun 14, 2024
| @@ -220,8 +220,8 @@ func (s *Server) produceBlockV3(ctx context.Context, w http.ResponseWriter, r *h | |||
|
|
|||
| consensusBlockValue, httpError := getConsensusBlockValue(ctx, s.BlockRewardFetcher, v1alpha1resp.Block) | |||
| if httpError != nil { | |||
| httputil.WriteError(w, httpError) | |||
| return | |||
| // Having the consensus block value is not critical to block production | |||
There was a problem hiding this comment.
we should warn or add something in the header maybe?
james-prysm
approved these changes
Jun 14, 2024
prestonvanloon
approved these changes
Jun 14, 2024
saolyn
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
We sometimes see sync committee signature verification failures when trying to get sync committee rewards for a given block. The reason for this bug is still unknown, but failing block production because of such a non-critical thing is too radical.
Which issues(s) does this PR fix?
Fixes #13910
Other notes for review
I modified the comment for Phase 0 to explain why we ignore it.